Skip to content

fix(nextjs): Apply Webpack configuration in dev mode #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2022
Merged

fix(nextjs): Apply Webpack configuration in dev mode #6291

merged 2 commits into from
Nov 24, 2022

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Nov 24, 2022

Fixes #6284

This PR fixes that our Webpack configuration didn't get picked up in dev mode.

@lforst lforst requested review from Lms24 and AbhiPrasad November 24, 2022 14:15
AbhiPrasad
AbhiPrasad reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this?

Also needs a quick release I assume?

@lforst
Copy link
Contributor Author

lforst commented Nov 24, 2022

Can we test this?

Also needs a quick release I assume?

We don't have a test setup for dev mode. I don't consider it worth the effort.

Doesn't need to be released immediately IMO. It only affects dev mode so most production systems should be unaffected.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.03% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.01% 🔺)
@sentry/replay index.js 83.67 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 83.69 KB (+0.02% 🔺)
@sentry/replay - Webpack (minified) 272.17 KB (+0.03% 🔺)

@lforst lforst merged commit f1e59f9 into master Nov 24, 2022
@lforst lforst deleted the lforst-fix-dev-mode branch November 24, 2022 16:18
@simPod simPod mentioned this pull request Nov 30, 2022
Closed
3 tasks
@kylemh kylemh mentioned this pull request Dec 6, 2022
Closed
3 tasks
@seanparmelee seanparmelee mentioned this pull request Jan 6, 2023
Closed
@baraeb92 baraeb92 mentioned this pull request Jan 17, 2023
Closed
3 tasks
@lforst lforst mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/nextjs v.7.21.1 broke "npm run dev" - works for v.7.21.0
2 participants
@lforst @AbhiPrasad